feat(prowlarr): #31 Added prowlarr and extra lb annotations #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since 90% of the code is similar between all these tools, I think we should look into a way to abstract them into a common chart and just add the differences in. |
kubealex
requested changes
Nov 27, 2022
There was a problem hiding this comment.
LGTM overall, some changes needed:
- Document the extraLBService annotations in the README for each component
- Document the Prowlarr values in the readme
- Review the Prowlarr definition, some typos are present (referencing jackett, mostly)
- Edit the k8s-mediaserver.yml according to the new values.yaml (copy/paste + indent is enough)
kubealex
approved these changes
Dec 7, 2022
kubealex
changed the title
|
@InputObject2 I had to revert this one as integrations tests are failing on ingress wget, am I missing something? - #58 |
|
@kubealex Annotations are not working for me with ArgoCD and Helm chat in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31